Mldsa functional tests#780
Open
bjwtaylor wants to merge 1 commit into
Open
Conversation
bjwtaylor
force-pushed
the
mldsa-functional-tests
branch
from
85fbee2 to
607504a
Compare
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
bjwtaylor
force-pushed
the
mldsa-functional-tests
branch
from
eb23704 to
1778197
Compare
bjwtaylor
added
needs-review
valeriosetti
requested changes
Jun 5, 2026
| # This condition deliberately runs when all.sh sources this file. It hides the | ||
| # component from both `--list-all-components` and explicit component requests on | ||
| # runners whose Python is too old for mldsa-native's generated-test checks. | ||
| if support_test_pqcp_mldsa_native_upstream_all; then |
Contributor
There was a problem hiding this comment.
Sure I'm missing something here, but is this if statement required?
I read the comment above that explains it, but as far as I remember the machinery that instruments our testing already does this. In support of my comment I don't see any other test component_xxx with an associated support_xxx with the if check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add mldsa functional tests to all.sh, resolves #641
PR checklist